Skip to content

Draft: Resolve "[ENG] DIB FY25 Report"

Megan Filo requested to merge 3555-eng-dib-fy25-report into main

https://3555-eng-dib-fy25-report.about.gitlab-review.app/diversity-inclusion-belonging/

Related to #3555

Files

Figma

Content Doc

What is changing in this MR?

  1. Complete overhaul of our Diversity, Inclusion, and Belonging page!
  2. Content is being switched over to JSON as we explore options of storing content back in our repo that we do not want to live in Contentful due to complexity reasons
  3. A lot of net-new components and very much not DRY code to meet our due date (May 22 - ultimately pushed back)
  4. An accessibility audit with a screen reader was done + analytics attributes were reviewed
  5. Removal of old DIB page components to keep things clean

TODO

Hoping to get to this before PTO, but hoping they will not be blockers. I can definitely handle these when I get back via follow-up MR!

  • Hydration errors. A quick check of our markdown blocks didn't show anything odd so I'll need to take a much closer look. As far as I can tell, this is not causing any bubbled GA events, broken content, or anything like that 👀
    • I narrowed it down to the Pillar 2 component, but I still don't see anything odd like incorrect HTML nesting or elements without closing tags that would cause something like this.
  • Refactor component imports to live in the DIB component index file
  • Put hardcoded SVG (quote img) in a reusable component
Edited by Megan Filo

Merge request reports