Skip to content

fix: Sets no-sort-reset for all tables

Marcel van Remmerden requested to merge remove-no-sort-reset into main

What does this MR do?

Previously only 5 of the ~125 tables in gitlab-org/gitlab had the no-sort-reset prop enabled. However, even the gitlab-ui default story didn't show that behavior, as the prop was manually set for that default story, making it behave different to the majority of actual tables inside our product.

To make our table experience more consistent, this MR thus now enables that behavior for all of them and removes the possibility to configure it differently for table implementations inside gitlab-org/gitlab.

Screenshots or screen recordings

Before After
Kapture_2024-05-03_at_09.28.25 Kapture_2024-05-03_at_09.21.28

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Merge request reports